summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobert Yang <liezhi.yang@windriver.com>2011-11-30 09:23:51 (GMT)
committerRichard Purdie <richard.purdie@linuxfoundation.org>2011-12-05 16:16:10 (GMT)
commit2639c37b25d5c19b92e8a4ce65075a6d807ff16e (patch)
tree6f3f148e9f60adf6d5f2bc9438e07a03a1273811
parent897d1cd951efec07e326b129846306b27e03c9e5 (diff)
downloadpoky-2639c37b25d5c19b92e8a4ce65075a6d807ff16e.tar.gz
Remove the async_cmds and sync_cmds from command.py
In bitbake/lib/bb/command.py::Command::__init__, we have the following lines: for attr in CommandsSync.__dict__: command = attr[:].lower() method = getattr(CommandsSync, attr) sync_cmds[command] = (method) for attr in CommandsAsync.__dict__: command = attr[:].lower() method = getattr(CommandsAsync, attr) async_cmds[command] = (method) The sync_cmds and async_cmds are defined as global dictionaries, but it seems that we've never used them (I did a "grep -r async_cmds bitbake/", , there is no result except the ones that I have removed), and I can't find the history of it from "git log -p", I guess that they have been replaced by the self.cmds_sync and self.cmds_async. [YOCTO #1791] (Bitbake rev: 24e99460800856035bb54a84c7aa33b3517436e9) Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--bitbake/lib/bb/command.py14
1 files changed, 0 insertions, 14 deletions
diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py
index 1808f0c..83907f6 100644
--- a/bitbake/lib/bb/command.py
+++ b/bitbake/lib/bb/command.py
@@ -31,10 +31,6 @@ Commands are queued in a CommandQueue
31import bb.event 31import bb.event
32import bb.cooker 32import bb.cooker
33 33
34async_cmds = {}
35sync_cmds = {}
36
37
38class CommandCompleted(bb.event.Event): 34class CommandCompleted(bb.event.Event):
39 pass 35 pass
40 36
@@ -60,16 +56,6 @@ class Command:
60 # FIXME Add lock for this 56 # FIXME Add lock for this
61 self.currentAsyncCommand = None 57 self.currentAsyncCommand = None
62 58
63 for attr in CommandsSync.__dict__:
64 command = attr[:].lower()
65 method = getattr(CommandsSync, attr)
66 sync_cmds[command] = (method)
67
68 for attr in CommandsAsync.__dict__:
69 command = attr[:].lower()
70 method = getattr(CommandsAsync, attr)
71 async_cmds[command] = (method)
72
73 def runCommand(self, commandline): 59 def runCommand(self, commandline):
74 try: 60 try:
75 command = commandline.pop(0) 61 command = commandline.pop(0)