diff options
author | Bruce Ashfield <bruce.ashfield@gmail.com> | 2019-07-22 14:48:07 +0000 |
---|---|---|
committer | Bruce Ashfield <bruce.ashfield@gmail.com> | 2019-07-22 14:48:07 +0000 |
commit | 95b848f2198018b44e44f3526a9de67a3c89c3c7 (patch) | |
tree | f9207787606034cd92bf12fe2e682a41b3af5f6b | |
parent | 37a554a2491499aabc88959348544e325e533f71 (diff) | |
download | meta-virtualization-95b848f2198018b44e44f3526a9de67a3c89c3c7.tar.gz |
containers/go/build: don't override global package strip flags
When the go-lang container recipes were first created there were issues
with strip and the resulting binaries. As such, strip was inhibited for
the various packages.
This variable is now set in the default classes, and tests show that
strip works on the binaries (saving up to 2M on disk for some binaries)
with no runtime issues found.
So we drop our explicit set of the inhibit and let the build proceed
by the defaults.
If issues are found, we can re-enable the setting or bbappends can
turn it back on for builds showing issues.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
-rw-r--r-- | recipes-containers/containerd/containerd.inc | 1 | ||||
-rw-r--r-- | recipes-containers/cri-o/cri-o_git.bb | 1 | ||||
-rw-r--r-- | recipes-containers/docker/docker.inc | 2 | ||||
-rw-r--r-- | recipes-containers/kubernetes/kubernetes_git.bb | 1 | ||||
-rw-r--r-- | recipes-containers/runc/runc.inc | 1 | ||||
-rw-r--r-- | recipes-core/runv/runv_git.bb | 1 | ||||
-rw-r--r-- | recipes-networking/cni/cni_git.bb | 1 |
7 files changed, 0 insertions, 8 deletions
diff --git a/recipes-containers/containerd/containerd.inc b/recipes-containers/containerd/containerd.inc index 2a2d8c5c..e226edf1 100644 --- a/recipes-containers/containerd/containerd.inc +++ b/recipes-containers/containerd/containerd.inc | |||
@@ -95,7 +95,6 @@ do_install() { | |||
95 | 95 | ||
96 | FILES_${PN} += "${systemd_system_unitdir}/*" | 96 | FILES_${PN} += "${systemd_system_unitdir}/*" |
97 | 97 | ||
98 | INHIBIT_PACKAGE_STRIP = "1" | ||
99 | INSANE_SKIP_${PN} += "ldflags already-stripped" | 98 | INSANE_SKIP_${PN} += "ldflags already-stripped" |
100 | 99 | ||
101 | COMPATIBLE_HOST = "^(?!(qemu)?mips).*" | 100 | COMPATIBLE_HOST = "^(?!(qemu)?mips).*" |
diff --git a/recipes-containers/cri-o/cri-o_git.bb b/recipes-containers/cri-o/cri-o_git.bb index 1a56dc45..c27aef78 100644 --- a/recipes-containers/cri-o/cri-o_git.bb +++ b/recipes-containers/cri-o/cri-o_git.bb | |||
@@ -143,7 +143,6 @@ FILES_${PN}-config = "${sysconfdir}/crio/config/*" | |||
143 | FILES_${PN} += "${systemd_unitdir}/system/*" | 143 | FILES_${PN} += "${systemd_unitdir}/system/*" |
144 | FILES_${PN} += "/usr/local/bin/*" | 144 | FILES_${PN} += "/usr/local/bin/*" |
145 | 145 | ||
146 | INHIBIT_PACKAGE_STRIP = "1" | ||
147 | INSANE_SKIP_${PN} += "ldflags already-stripped" | 146 | INSANE_SKIP_${PN} += "ldflags already-stripped" |
148 | 147 | ||
149 | deltask compile_ptest_base | 148 | deltask compile_ptest_base |
diff --git a/recipes-containers/docker/docker.inc b/recipes-containers/docker/docker.inc index eacaf7f4..149ca824 100644 --- a/recipes-containers/docker/docker.inc +++ b/recipes-containers/docker/docker.inc | |||
@@ -52,6 +52,4 @@ GROUPADD_PARAM_${PN} = "-r docker" | |||
52 | 52 | ||
53 | COMPATIBLE_HOST = "^(?!(qemu)?mips).*" | 53 | COMPATIBLE_HOST = "^(?!(qemu)?mips).*" |
54 | 54 | ||
55 | # DO NOT STRIP docker | ||
56 | INHIBIT_PACKAGE_STRIP = "1" | ||
57 | INSANE_SKIP_${PN} += "ldflags textrel" | 55 | INSANE_SKIP_${PN} += "ldflags textrel" |
diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb index 516afa31..ea347197 100644 --- a/recipes-containers/kubernetes/kubernetes_git.bb +++ b/recipes-containers/kubernetes/kubernetes_git.bb | |||
@@ -106,6 +106,5 @@ FILES_kubectl = "${bindir}/kubectl" | |||
106 | FILES_kube-proxy = "${bindir}/kube-proxy" | 106 | FILES_kube-proxy = "${bindir}/kube-proxy" |
107 | FILES_${PN}-misc = "${bindir}" | 107 | FILES_${PN}-misc = "${bindir}" |
108 | 108 | ||
109 | INHIBIT_PACKAGE_STRIP = "1" | ||
110 | 109 | ||
111 | deltask compile_ptest_base | 110 | deltask compile_ptest_base |
diff --git a/recipes-containers/runc/runc.inc b/recipes-containers/runc/runc.inc index 5a2ca31a..46fd09dc 100644 --- a/recipes-containers/runc/runc.inc +++ b/recipes-containers/runc/runc.inc | |||
@@ -64,4 +64,3 @@ do_install() { | |||
64 | ln -sf runc ${D}/${bindir}/docker-runc | 64 | ln -sf runc ${D}/${bindir}/docker-runc |
65 | } | 65 | } |
66 | 66 | ||
67 | INHIBIT_PACKAGE_STRIP = "1" | ||
diff --git a/recipes-core/runv/runv_git.bb b/recipes-core/runv/runv_git.bb index 0301dd28..ef94f096 100644 --- a/recipes-core/runv/runv_git.bb +++ b/recipes-core/runv/runv_git.bb | |||
@@ -78,5 +78,4 @@ deltask compile_ptest_base | |||
78 | 78 | ||
79 | FILES_${PN} += "/usr/local/bin/*" | 79 | FILES_${PN} += "/usr/local/bin/*" |
80 | 80 | ||
81 | INHIBIT_PACKAGE_STRIP = "1" | ||
82 | INSANE_SKIP_${PN} += "ldflags already-stripped" | 81 | INSANE_SKIP_${PN} += "ldflags already-stripped" |
diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/cni_git.bb index 4c1714ae..d07154bb 100644 --- a/recipes-networking/cni/cni_git.bb +++ b/recipes-networking/cni/cni_git.bb | |||
@@ -92,7 +92,6 @@ do_install() { | |||
92 | 92 | ||
93 | FILES_${PN} += "/opt/cni/bin/*" | 93 | FILES_${PN} += "/opt/cni/bin/*" |
94 | 94 | ||
95 | INHIBIT_PACKAGE_STRIP = "1" | ||
96 | INSANE_SKIP_${PN} += "ldflags already-stripped" | 95 | INSANE_SKIP_${PN} += "ldflags already-stripped" |
97 | 96 | ||
98 | deltask compile_ptest_base | 97 | deltask compile_ptest_base |