diff options
| author | Patrick Vacek <patrickvacek@gmail.com> | 2018-10-09 17:28:55 +0200 |
|---|---|---|
| committer | Patrick Vacek <patrickvacek@gmail.com> | 2018-10-29 14:30:01 +0100 |
| commit | 52950e02193e85f39385fe54bd681146e4670e08 (patch) | |
| tree | ee81c7e8627018209e09e0ca9b108643019055a2 | |
| parent | 3f3e06444373e08dce0ae33a4c936cfcf2ad3e15 (diff) | |
| download | meta-updater-52950e02193e85f39385fe54bd681146e4670e08.tar.gz | |
CONTRIBUTING.adoc: Add rebasing requirement.
| -rw-r--r-- | CONTRIBUTING.adoc | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/CONTRIBUTING.adoc b/CONTRIBUTING.adoc index b719d30..73fc3c3 100644 --- a/CONTRIBUTING.adoc +++ b/CONTRIBUTING.adoc | |||
| @@ -6,12 +6,14 @@ If you are developing with meta-updater, it may be helpful to read the README an | |||
| 6 | 6 | ||
| 7 | == Contributor checklist | 7 | == Contributor checklist |
| 8 | 8 | ||
| 9 | * OTA-enabled build succeeds at least for one platform, the resulted image boots. This check is absolutely necessary for every pull request unless it only touches documentation. | 9 | * OTA-enabled build succeeds at least for one platform, the resulted image boots, and an update can be installed. This check is absolutely necessary for every pull request unless it only touches documentation. |
| 10 | * If your change is touching platform code (like `classes/sota_<platform>.bbclass`), please check build and update on this particular platform. | 10 | * If your change touches platform code (like `classes/sota_<platform>.bbclass`), please check building and updating on this particular platform. |
| 11 | * oe-selftest succeeds. To test meta-updater, run `oe-selftest -r updater` from a build directory with `MACHINE` set to `qemux86-64`. | 11 | * oe-selftest succeeds. To test meta-updater, run `oe-selftest -r updater` from a build directory with `MACHINE` set to `qemux86-64`. |
| 12 | * Updates are forwards- and backwards-compatible. You should be able to update an OTA-enabled build before the change is applied to the version with change applied and vice versa. One should pay double attention to the compatibility when bootloader code is affected. | 12 | * Updates are forwards- and backwards-compatible. You should be able to update an OTA-enabled build before the change is applied to the version with change applied and vice versa. One should pay double attention to the compatibility when bootloader code is affected. |
| 13 | * The patch/branch should be based on the latest version of the target branch. This may mean that rebasing is necessary if other PRs are merged before yours is approved. | ||
| 13 | 14 | ||
| 14 | We understand that making all these tests might be overly tedious taking in account build times in Yocto. Please add a comment to your PR describing the tests you've made. | 15 | We understand that completing all these tasks might be overly tedious due to build times in Yocto. Please add a comment to your PR describing the tests you've done. |
| 15 | 16 | ||
| 16 | == Approval | 17 | == Approval |
| 17 | PR approval should be accompanied by a comment describing what tests have been made by the reviewer. | 18 | |
| 19 | PR approval should be accompanied by a comment describing what tests have been done by the reviewer. | ||