summaryrefslogtreecommitdiffstats
path: root/recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch
diff options
context:
space:
mode:
authorKoen Kooi <koen@dominion.thruhere.net>2012-05-23 11:20:07 +0200
committerDenys Dmytriyenko <denys@ti.com>2012-05-30 13:49:03 -0400
commit2177f80076ebc15cc58fb521b58e49c83315f34e (patch)
tree3690868d86f360c07c79ea21269ec198293dbec2 /recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch
parentd9d51a11b8ff53c5ee7ef12e221479a24e071f13 (diff)
downloadmeta-ti-2177f80076ebc15cc58fb521b58e49c83315f34e.tar.gz
linux-ti33x-psp 3.2: update to 3.2.18
Duplicate patches between PSP and 3.2.17 have been dropped from the 3.2.17 series Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Diffstat (limited to 'recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch')
-rw-r--r--recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch47
1 files changed, 47 insertions, 0 deletions
diff --git a/recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch b/recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch
new file mode 100644
index 00000000..199864f5
--- /dev/null
+++ b/recipes-kernel/linux/linux-ti33x-psp-3.2/3.2.18/0013-net-l2tp-unlock-socket-lock-before-returning-from-l2.patch
@@ -0,0 +1,47 @@
1From 1b3ded810906676f03b6eab986308b1cf5e6b135 Mon Sep 17 00:00:00 2001
2From: Sasha Levin <levinsasha928@gmail.com>
3Date: Wed, 2 May 2012 03:58:43 +0000
4Subject: [PATCH 13/56] net: l2tp: unlock socket lock before returning from
5 l2tp_ip_sendmsg
6
7[ Upstream commit 84768edbb2721637620b2d84501bb0d5aed603f1 ]
8
9l2tp_ip_sendmsg could return without releasing socket lock, making it all the
10way to userspace, and generating the following warning:
11
12[ 130.891594] ================================================
13[ 130.894569] [ BUG: lock held when returning to user space! ]
14[ 130.897257] 3.4.0-rc5-next-20120501-sasha #104 Tainted: G W
15[ 130.900336] ------------------------------------------------
16[ 130.902996] trinity/8384 is leaving the kernel with locks still held!
17[ 130.906106] 1 lock held by trinity/8384:
18[ 130.907924] #0: (sk_lock-AF_INET){+.+.+.}, at: [<ffffffff82b9503f>] l2tp_ip_sendmsg+0x2f/0x550
19
20Introduced by commit 2f16270 ("l2tp: Fix locking in l2tp_ip.c").
21
22Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
23Acked-by: Eric Dumazet <edumazet@google.com>
24Signed-off-by: David S. Miller <davem@davemloft.net>
25Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
26---
27 net/l2tp/l2tp_ip.c | 3 ++-
28 1 files changed, 2 insertions(+), 1 deletions(-)
29
30diff --git a/net/l2tp/l2tp_ip.c b/net/l2tp/l2tp_ip.c
31index 55670ec..2a2a3e7 100644
32--- a/net/l2tp/l2tp_ip.c
33+++ b/net/l2tp/l2tp_ip.c
34@@ -441,8 +441,9 @@ static int l2tp_ip_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *m
35
36 daddr = lip->l2tp_addr.s_addr;
37 } else {
38+ rc = -EDESTADDRREQ;
39 if (sk->sk_state != TCP_ESTABLISHED)
40- return -EDESTADDRREQ;
41+ goto out;
42
43 daddr = inet->inet_daddr;
44 connected = 1;
45--
461.7.7.6
47