From 511d965d6dd440fc0ae6b702feff06cb6718140e Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Thu, 20 Nov 2025 00:05:55 -0800 Subject: [PATCH] python3-scapy: skip ICMP regression tests in ptest The UTScapy regression campaign contains two ICMP-based tests: - "Latency check: localhost ICMP" - "Sending and receiving an ICMPv6EchoRequest" Both rely on raw ICMP sockets and/or external IPv6 connectivity (www.google.com), which are not guaranteed to be available in the ptest environment. As a result they systematically fail and cause the whole ptest run to be reported as failed. Tag these tests with the "skipped_ptest" keyword so they can be filtered out by the ptest runner via `-K skipped_ptest`. Additionally, mark the ICMPv6 test with `@pytest.mark.skip` to avoid running it under pytest-based harnesses that import regression.uts. This keeps ptest results stable while still allowing developers to run these tests manually in a properly networked environment. Upstream-Status: Inappropriate [OE-specific] Signed-off-by: Khem Raj --- test/regression.uts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/test/regression.uts +++ b/test/regression.uts @@ -1732,7 +1732,7 @@ def _test(): retry_test(_test) = Latency check: localhost ICMP -~ netaccess needs_root linux latency +~ netaccess needs_root linux latency skipped_ptest # Note: still needs to enforce L3RawSocket as this won't work otherwise with libpcap sock = conf.L3socket @@ -1840,7 +1840,7 @@ finally: sck.close() = Sending and receiving an ICMPv6EchoRequest -~ netaccess ipv6 +~ netaccess ipv6 skipped_ptest def _test(): with no_debug_dissector(): x = sr1(IPv6(dst="www.google.com")/ICMPv6EchoRequest(),timeout=3)