summaryrefslogtreecommitdiffstats
path: root/meta-webserver/recipes-httpd/apache2/files/CVE-2018-1333.patch
diff options
context:
space:
mode:
Diffstat (limited to 'meta-webserver/recipes-httpd/apache2/files/CVE-2018-1333.patch')
-rw-r--r--meta-webserver/recipes-httpd/apache2/files/CVE-2018-1333.patch44
1 files changed, 44 insertions, 0 deletions
diff --git a/meta-webserver/recipes-httpd/apache2/files/CVE-2018-1333.patch b/meta-webserver/recipes-httpd/apache2/files/CVE-2018-1333.patch
new file mode 100644
index 000000000..9cd207c04
--- /dev/null
+++ b/meta-webserver/recipes-httpd/apache2/files/CVE-2018-1333.patch
@@ -0,0 +1,44 @@
1From 83a2e3866918ce6567a683eb4c660688d047ee81 Mon Sep 17 00:00:00 2001
2From: Stefan Eissing <stefan.eissing@greenbytes.de>
3Date: Wed, 18 Apr 2018 11:55:17 +0200
4Subject: [PATCH] * fixes a race condition where aborting streams triggers an
5 unnecessary timeout.
6
7Note: Re-factored upstream fix
8https://github.com/icing/mod_h2/commit/83a2e3866918ce6567a683eb4c660688d047ee81,
9so that it applies to httpd v2.4.27 code. Similarly done at
10http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_bucket_beam.c?r1=1828879&r2=1828878&pathrev=1828879
11
12CVE: CVE-2018-1333
13Upstream-Status: Backport [https://github.com/icing/mod_h2/commit/83a2e3866918ce6567a683eb4c660688d047ee81]
14
15Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
16
17diff -Naurp httpd-2.4.27_org/modules/http2/h2_bucket_beam.c httpd-2.4.27/modules/http2/h2_bucket_beam.c
18--- httpd-2.4.27_org/modules/http2/h2_bucket_beam.c 2017-04-21 06:52:05.000000000 -0700
19+++ httpd-2.4.27/modules/http2/h2_bucket_beam.c 2018-07-24 23:44:40.888330955 -0700
20@@ -512,6 +512,7 @@ static void recv_buffer_cleanup(h2_bucke
21 apr_brigade_destroy(bb);
22 if (bl) enter_yellow(beam, bl);
23
24+ apr_thread_cond_broadcast(beam->change);
25 if (beam->cons_ev_cb) {
26 beam->cons_ev_cb(beam->cons_ctx, beam);
27 }
28@@ -685,12 +686,10 @@ void h2_beam_abort(h2_bucket_beam *beam)
29 h2_beam_lock bl;
30
31 if (enter_yellow(beam, &bl) == APR_SUCCESS) {
32- if (!beam->aborted) {
33- beam->aborted = 1;
34- r_purge_sent(beam);
35- h2_blist_cleanup(&beam->send_list);
36- report_consumption(beam, &bl);
37- }
38+ beam->aborted = 1;
39+ r_purge_sent(beam);
40+ h2_blist_cleanup(&beam->send_list);
41+ report_consumption(beam, &bl);
42 if (beam->cond) {
43 apr_thread_cond_broadcast(beam->cond);
44 }