diff options
Diffstat (limited to 'meta-oe/recipes-test/fwts/fwts/0003-use-intptr_t-to-fix-pointer-to-int-cast-issues.patch')
-rw-r--r-- | meta-oe/recipes-test/fwts/fwts/0003-use-intptr_t-to-fix-pointer-to-int-cast-issues.patch | 52 |
1 files changed, 25 insertions, 27 deletions
diff --git a/meta-oe/recipes-test/fwts/fwts/0003-use-intptr_t-to-fix-pointer-to-int-cast-issues.patch b/meta-oe/recipes-test/fwts/fwts/0003-use-intptr_t-to-fix-pointer-to-int-cast-issues.patch index 3cd3fbbc1..bebbfa4ad 100644 --- a/meta-oe/recipes-test/fwts/fwts/0003-use-intptr_t-to-fix-pointer-to-int-cast-issues.patch +++ b/meta-oe/recipes-test/fwts/fwts/0003-use-intptr_t-to-fix-pointer-to-int-cast-issues.patch | |||
@@ -1,13 +1,14 @@ | |||
1 | From d0d76820efe51dd404d381fc4c46544008e757dd Mon Sep 17 00:00:00 2001 | 1 | From 1848b8f8b9be500046ca5d632789a068d6151815 Mon Sep 17 00:00:00 2001 |
2 | From: Khem Raj <raj.khem@gmail.com> | 2 | From: Khem Raj <raj.khem@gmail.com> |
3 | Date: Thu, 8 Jun 2017 16:50:59 -0700 | 3 | Date: Thu, 8 Jun 2017 16:50:59 -0700 |
4 | Subject: [PATCH 3/3] use intptr_t to fix pointer-to-int-cast issues | 4 | Subject: [PATCH] use intptr_t to fix pointer-to-int-cast issues |
5 | 5 | ||
6 | uintptr_t is guaranteed to be wide enough that | 6 | uintptr_t is guaranteed to be wide enough that |
7 | converting a void* to uintptr_t and back again | 7 | converting a void* to uintptr_t and back again |
8 | will yield the original pointer value | 8 | will yield the original pointer value |
9 | 9 | ||
10 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | 10 | Signed-off-by: Khem Raj <raj.khem@gmail.com> |
11 | |||
11 | --- | 12 | --- |
12 | src/lib/src/fwts_acpi_tables.c | 4 ++-- | 13 | src/lib/src/fwts_acpi_tables.c | 4 ++-- |
13 | src/lib/src/fwts_mmap.c | 2 +- | 14 | src/lib/src/fwts_mmap.c | 2 +- |
@@ -15,19 +16,19 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com> | |||
15 | 3 files changed, 5 insertions(+), 5 deletions(-) | 16 | 3 files changed, 5 insertions(+), 5 deletions(-) |
16 | 17 | ||
17 | diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c | 18 | diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c |
18 | index 832f8d66..d0006529 100644 | 19 | index 58e982a6..6522032f 100644 |
19 | --- a/src/lib/src/fwts_acpi_tables.c | 20 | --- a/src/lib/src/fwts_acpi_tables.c |
20 | +++ b/src/lib/src/fwts_acpi_tables.c | 21 | +++ b/src/lib/src/fwts_acpi_tables.c |
21 | @@ -150,7 +150,7 @@ static fwts_acpi_table_rsdp *fwts_acpi_get_rsdp(fwts_framework *fw, void *addr, | 22 | @@ -156,7 +156,7 @@ static fwts_acpi_table_rsdp *fwts_acpi_get_rsdp(fwts_framework *fw, void *addr, |
22 | fwts_acpi_table_rsdp *rsdp = NULL; | 23 | return NULL; |
23 | *rsdp_len = 0; | 24 | } |
24 | 25 | ||
25 | - if ((mem = fwts_mmap((off_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED) | 26 | - if ((mem = fwts_mmap((off_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED) |
26 | + if ((mem = fwts_mmap((uintptr_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED) | 27 | + if ((mem = fwts_mmap((uintptr_t)addr, sizeof(fwts_acpi_table_rsdp))) == FWTS_MAP_FAILED) |
27 | return NULL; | 28 | return NULL; |
28 | 29 | ||
29 | if (fwts_safe_memread(mem, sizeof(fwts_acpi_table_rsdp)) != FWTS_OK) { | 30 | if (fwts_safe_memcpy(rsdp, mem, sizeof(fwts_acpi_table_rsdp)) != FWTS_OK) { |
30 | @@ -456,7 +456,7 @@ static int fwts_acpi_load_tables_from_firmware(fwts_framework *fw) | 31 | @@ -455,7 +455,7 @@ static int fwts_acpi_load_tables_from_firmware(fwts_framework *fw) |
31 | if ((rsdp = fwts_acpi_get_rsdp(fw, rsdp_addr, &rsdp_len)) == NULL) | 32 | if ((rsdp = fwts_acpi_get_rsdp(fw, rsdp_addr, &rsdp_len)) == NULL) |
32 | return FWTS_ERROR; | 33 | return FWTS_ERROR; |
33 | 34 | ||
@@ -37,7 +38,7 @@ index 832f8d66..d0006529 100644 | |||
37 | /* Load any tables from XSDT if it's valid */ | 38 | /* Load any tables from XSDT if it's valid */ |
38 | if (rsdp->xsdt_address) { | 39 | if (rsdp->xsdt_address) { |
39 | diff --git a/src/lib/src/fwts_mmap.c b/src/lib/src/fwts_mmap.c | 40 | diff --git a/src/lib/src/fwts_mmap.c b/src/lib/src/fwts_mmap.c |
40 | index a09f688e..9fe6329a 100644 | 41 | index e28abf87..2180b2cc 100644 |
41 | --- a/src/lib/src/fwts_mmap.c | 42 | --- a/src/lib/src/fwts_mmap.c |
42 | +++ b/src/lib/src/fwts_mmap.c | 43 | +++ b/src/lib/src/fwts_mmap.c |
43 | @@ -81,7 +81,7 @@ int fwts_munmap(void *mem, const size_t size) | 44 | @@ -81,7 +81,7 @@ int fwts_munmap(void *mem, const size_t size) |
@@ -50,27 +51,24 @@ index a09f688e..9fe6329a 100644 | |||
50 | if (munmap((void *)((uint8_t *)mem - offset), size + offset) < 0) | 51 | if (munmap((void *)((uint8_t *)mem - offset), size + offset) < 0) |
51 | return FWTS_ERROR; | 52 | return FWTS_ERROR; |
52 | diff --git a/src/lib/src/fwts_smbios.c b/src/lib/src/fwts_smbios.c | 53 | diff --git a/src/lib/src/fwts_smbios.c b/src/lib/src/fwts_smbios.c |
53 | index 8d0ea39b..63b4bf25 100644 | 54 | index e5b3c774..c8134926 100644 |
54 | --- a/src/lib/src/fwts_smbios.c | 55 | --- a/src/lib/src/fwts_smbios.c |
55 | +++ b/src/lib/src/fwts_smbios.c | 56 | +++ b/src/lib/src/fwts_smbios.c |
56 | @@ -54,7 +54,7 @@ static void *fwts_smbios_find_entry_uefi(fwts_framework *fw, fwts_smbios_entry * | 57 | @@ -55,7 +55,7 @@ static void *fwts_smbios_find_entry_uefi(fwts_framework *fw, fwts_smbios_entry * |
57 | if ((addr = fwts_scan_efi_systab("SMBIOS")) != NULL) { | ||
58 | fwts_smbios_entry *mapped_entry; | 58 | fwts_smbios_entry *mapped_entry; |
59 | const size_t size = sizeof(fwts_smbios_entry); | ||
59 | 60 | ||
60 | - if ((mapped_entry = fwts_mmap((off_t)addr, sizeof(fwts_smbios_entry))) != FWTS_MAP_FAILED) { | 61 | - if ((mapped_entry = fwts_mmap((off_t)addr, size)) != FWTS_MAP_FAILED) { |
61 | + if ((mapped_entry = fwts_mmap((uintptr_t)addr, sizeof(fwts_smbios_entry))) != FWTS_MAP_FAILED) { | 62 | + if ((mapped_entry = fwts_mmap((uintptr_t)addr, size)) != FWTS_MAP_FAILED) { |
62 | *entry = *mapped_entry; | 63 | if (fwts_safe_memcpy(entry, mapped_entry, size) == FWTS_OK) { |
63 | (void)fwts_munmap(mapped_entry, sizeof(fwts_smbios_entry)); | 64 | (void)fwts_munmap(mapped_entry, size); |
64 | *type = FWTS_SMBIOS; | 65 | *type = FWTS_SMBIOS; |
65 | @@ -84,7 +84,7 @@ static void *fwts_smbios30_find_entry_uefi(fwts_framework *fw, fwts_smbios30_ent | 66 | @@ -91,7 +91,7 @@ static void *fwts_smbios30_find_entry_uefi(fwts_framework *fw, fwts_smbios30_ent |
66 | if ((addr = fwts_scan_efi_systab("SMBIOS3")) != NULL) { | ||
67 | fwts_smbios30_entry *mapped_entry; | 67 | fwts_smbios30_entry *mapped_entry; |
68 | const size_t size = sizeof(fwts_smbios30_entry); | ||
68 | 69 | ||
69 | - if ((mapped_entry = fwts_mmap((off_t)addr, sizeof(fwts_smbios30_entry))) != FWTS_MAP_FAILED) { | 70 | - if ((mapped_entry = fwts_mmap((off_t)addr, size)) != FWTS_MAP_FAILED) { |
70 | + if ((mapped_entry = fwts_mmap((uintptr_t)addr, sizeof(fwts_smbios30_entry))) != FWTS_MAP_FAILED) { | 71 | + if ((mapped_entry = fwts_mmap((uintptr_t)addr, size)) != FWTS_MAP_FAILED) { |
71 | *entry = *mapped_entry; | 72 | if (fwts_safe_memread(mapped_entry, size) == FWTS_OK) { |
72 | (void)fwts_munmap(mapped_entry, sizeof(fwts_smbios30_entry)); | 73 | *entry = *mapped_entry; |
73 | return addr; | 74 | (void)fwts_munmap(mapped_entry, size); |
74 | -- | ||
75 | 2.13.1 | ||
76 | |||