diff options
| -rw-r--r-- | meta-oe/recipes-multimedia/v4l2apps/v4l-utils/0004-Do-not-use-getsubopt.patch | 60 | ||||
| -rw-r--r-- | meta-oe/recipes-multimedia/v4l2apps/v4l-utils_1.26.1.bb | 1 |
2 files changed, 0 insertions, 61 deletions
diff --git a/meta-oe/recipes-multimedia/v4l2apps/v4l-utils/0004-Do-not-use-getsubopt.patch b/meta-oe/recipes-multimedia/v4l2apps/v4l-utils/0004-Do-not-use-getsubopt.patch deleted file mode 100644 index fb844acbe4..0000000000 --- a/meta-oe/recipes-multimedia/v4l2apps/v4l-utils/0004-Do-not-use-getsubopt.patch +++ /dev/null | |||
| @@ -1,60 +0,0 @@ | |||
| 1 | From 6e7e52de7afe29597016952a7317faf9c3ea3268 Mon Sep 17 00:00:00 2001 | ||
| 2 | From: Khem Raj <raj.khem@gmail.com> | ||
| 3 | Date: Sat, 30 Nov 2019 18:50:34 -0800 | ||
| 4 | Subject: [PATCH] Do not use getsubopt | ||
| 5 | |||
| 6 | POSIX says that behavior when subopts list is empty is undefined. | ||
| 7 | musl libs will set value to NULL which leads to crash. | ||
| 8 | |||
| 9 | Simply avoid getsubopt, since we cannot rely on it. | ||
| 10 | |||
| 11 | Imported from Alpine Linux | ||
| 12 | |||
| 13 | Upstream-Status: Pending | ||
| 14 | |||
| 15 | Signed-off-by: Khem Raj <raj.khem@gmail.com> | ||
| 16 | |||
| 17 | Adapt patch to 1.23.0. | ||
| 18 | |||
| 19 | (v4l-utils rev fd544473800d02e90bc289434cc44e5aa8fadd0f). | ||
| 20 | |||
| 21 | %% original patch: 0007-Do-not-use-getsubopt.patch | ||
| 22 | |||
| 23 | Signed-off-by: Daniel Gomez <daniel@qtec.com> | ||
| 24 | --- | ||
| 25 | utils/v4l2-ctl/v4l2-ctl-common.cpp | 18 ++++++++++-------- | ||
| 26 | 1 file changed, 10 insertions(+), 8 deletions(-) | ||
| 27 | |||
| 28 | diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp | ||
| 29 | index d77f7104..838c297d 100644 | ||
| 30 | --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp | ||
| 31 | +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp | ||
| 32 | @@ -994,15 +994,17 @@ static bool parse_subset(char *optarg) | ||
| 33 | |||
| 34 | static bool parse_next_subopt(char **subs, char **value) | ||
| 35 | { | ||
| 36 | - static char *const subopts[] = { | ||
| 37 | - nullptr | ||
| 38 | - }; | ||
| 39 | - int opt = v4l_getsubopt(subs, subopts, value); | ||
| 40 | + char *p = *subs; | ||
| 41 | + *value = *subs; | ||
| 42 | |||
| 43 | - if (opt < 0 || *value) | ||
| 44 | - return false; | ||
| 45 | - fprintf(stderr, "Missing suboption value\n"); | ||
| 46 | - return true; | ||
| 47 | + while (*p && *p != ',') | ||
| 48 | + p++; | ||
| 49 | + | ||
| 50 | + if (*p) | ||
| 51 | + *p++ = '\0'; | ||
| 52 | + | ||
| 53 | + *subs = p; | ||
| 54 | + return false; | ||
| 55 | } | ||
| 56 | |||
| 57 | void common_cmd(const std::string &media_bus_info, int ch, char *optarg) | ||
| 58 | -- | ||
| 59 | 2.35.1 | ||
| 60 | |||
diff --git a/meta-oe/recipes-multimedia/v4l2apps/v4l-utils_1.26.1.bb b/meta-oe/recipes-multimedia/v4l2apps/v4l-utils_1.26.1.bb index 4ae1a18c9e..594b51b439 100644 --- a/meta-oe/recipes-multimedia/v4l2apps/v4l-utils_1.26.1.bb +++ b/meta-oe/recipes-multimedia/v4l2apps/v4l-utils_1.26.1.bb | |||
| @@ -28,7 +28,6 @@ PACKAGECONFIG[v4l2-tracer] = ",-Dv4l2-tracer=disabled,json-c" | |||
| 28 | SRC_URI = "\ | 28 | SRC_URI = "\ |
| 29 | git://git.linuxtv.org/v4l-utils.git;protocol=https;branch=stable-1.26 \ | 29 | git://git.linuxtv.org/v4l-utils.git;protocol=https;branch=stable-1.26 \ |
| 30 | file://0001-keytable-meson-Restrict-the-installation-of-50-rc_ke.patch \ | 30 | file://0001-keytable-meson-Restrict-the-installation-of-50-rc_ke.patch \ |
| 31 | file://0004-Do-not-use-getsubopt.patch \ | ||
| 32 | " | 31 | " |
| 33 | 32 | ||
| 34 | SRCREV = "4aee01a027923cab1e40969f56f8ba58d3e6c0d1" | 33 | SRCREV = "4aee01a027923cab1e40969f56f8ba58d3e6c0d1" |
