diff options
| -rw-r--r-- | meta-networking/recipes-irc/znc/znc/0001-Fix-NULL-pointer-dereference-in-webadmin.patch | 58 | ||||
| -rw-r--r-- | meta-networking/recipes-irc/znc/znc_git.bb | 13 |
2 files changed, 7 insertions, 64 deletions
diff --git a/meta-networking/recipes-irc/znc/znc/0001-Fix-NULL-pointer-dereference-in-webadmin.patch b/meta-networking/recipes-irc/znc/znc/0001-Fix-NULL-pointer-dereference-in-webadmin.patch deleted file mode 100644 index 68e4414704..0000000000 --- a/meta-networking/recipes-irc/znc/znc/0001-Fix-NULL-pointer-dereference-in-webadmin.patch +++ /dev/null | |||
| @@ -1,58 +0,0 @@ | |||
| 1 | Subject: [PATCH] Fix NULL pointer dereference in webadmin. | ||
| 2 | |||
| 3 | Upstream-Status: Backport | ||
| 4 | |||
| 5 | commit 2bd410ee5570cea127233f1133ea22f25174eb28 upstream | ||
| 6 | |||
| 7 | Triggerable by any non-admin, if webadmin is loaded. | ||
| 8 | |||
| 9 | The only affected version is 1.0 | ||
| 10 | |||
| 11 | Thanks to ChauffeR (Simone Esposito) for reporting this. | ||
| 12 | --- | ||
| 13 | modules/webadmin.cpp | 8 ++++---- | ||
| 14 | 1 file changed, 4 insertions(+), 4 deletions(-) | ||
| 15 | |||
| 16 | diff --git a/modules/webadmin.cpp b/modules/webadmin.cpp | ||
| 17 | index b793c02..816f217 100644 | ||
| 18 | --- a/modules/webadmin.cpp | ||
| 19 | +++ b/modules/webadmin.cpp | ||
| 20 | @@ -419,7 +419,7 @@ public: | ||
| 21 | CIRCNetwork* pNetwork = SafeGetNetworkFromParam(WebSock); | ||
| 22 | |||
| 23 | // Admin||Self Check | ||
| 24 | - if (!spSession->IsAdmin() && (!spSession->GetUser() || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 25 | + if (!spSession->IsAdmin() && (!spSession->GetUser() || !pNetwork || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 26 | return false; | ||
| 27 | } | ||
| 28 | |||
| 29 | @@ -448,7 +448,7 @@ public: | ||
| 30 | CIRCNetwork* pNetwork = SafeGetNetworkFromParam(WebSock); | ||
| 31 | |||
| 32 | // Admin||Self Check | ||
| 33 | - if (!spSession->IsAdmin() && (!spSession->GetUser() || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 34 | + if (!spSession->IsAdmin() && (!spSession->GetUser() || !pNetwork || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 35 | return false; | ||
| 36 | } | ||
| 37 | |||
| 38 | @@ -472,7 +472,7 @@ public: | ||
| 39 | CIRCNetwork* pNetwork = SafeGetNetworkFromParam(WebSock); | ||
| 40 | |||
| 41 | // Admin||Self Check | ||
| 42 | - if (!spSession->IsAdmin() && (!spSession->GetUser() || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 43 | + if (!spSession->IsAdmin() && (!spSession->GetUser() || !pNetwork || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 44 | return false; | ||
| 45 | } | ||
| 46 | |||
| 47 | @@ -486,7 +486,7 @@ public: | ||
| 48 | CIRCNetwork* pNetwork = SafeGetNetworkFromParam(WebSock); | ||
| 49 | |||
| 50 | // Admin||Self Check | ||
| 51 | - if (!spSession->IsAdmin() && (!spSession->GetUser() || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 52 | + if (!spSession->IsAdmin() && (!spSession->GetUser() || !pNetwork || spSession->GetUser() != pNetwork->GetUser())) { | ||
| 53 | return false; | ||
| 54 | } | ||
| 55 | |||
| 56 | -- | ||
| 57 | 1.8.5.2.233.g932f7e4 | ||
| 58 | |||
diff --git a/meta-networking/recipes-irc/znc/znc_git.bb b/meta-networking/recipes-irc/znc/znc_git.bb index 2e35e4dd33..d81c17052e 100644 --- a/meta-networking/recipes-irc/znc/znc_git.bb +++ b/meta-networking/recipes-irc/znc/znc_git.bb | |||
| @@ -1,16 +1,17 @@ | |||
| 1 | SUMMARY = "ZNC, an advanced IRC bouncer" | 1 | SUMMARY = "ZNC, an advanced IRC bouncer" |
| 2 | SECTION = "net" | 2 | SECTION = "net" |
| 3 | LICENSE = "GPLv2" | 3 | LICENSE = "GPLv2" |
| 4 | LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe" | 4 | LIC_FILES_CHKSUM = "file://LICENSE;md5=3b83ef96387f14655fc854ddc3c6bd57" |
| 5 | 5 | ||
| 6 | DEPENDS = "openssl" | 6 | DEPENDS = "openssl zlib icu" |
| 7 | 7 | ||
| 8 | PV = "1.0+git" | 8 | PV = "1.6.0" |
| 9 | 9 | ||
| 10 | SRCREV = "ef59c23068547c132cb678092fba9a21317fd5f2" | 10 | SRC_URI = "git://github.com/znc/znc.git;name=znc \ |
| 11 | SRC_URI = "git://github.com/znc/znc.git \ | 11 | git://github.com/jimloco/Csocket.git;destsuffix=git/third_party/Csocket;name=Csocket \ |
| 12 | file://0001-Fix-NULL-pointer-dereference-in-webadmin.patch \ | ||
| 13 | " | 12 | " |
| 13 | SRCREV_znc = "f47e8465efa4e1cd948b9caae93ac401b4355df8" | ||
| 14 | SRCREV_Csocket = "07b4437396122650e5b8fb3d014e820a5decf4ee" | ||
| 14 | 15 | ||
| 15 | S = "${WORKDIR}/git" | 16 | S = "${WORKDIR}/git" |
| 16 | 17 | ||
