summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Kiernan <alex.kiernan@gmail.com>2022-10-03 18:06:21 +0100
committerKhem Raj <raj.khem@gmail.com>2022-10-03 10:26:21 -0700
commit4b26cded9c747a2d610a8abf0f4549df48a1db5e (patch)
treec3d08cc5796512fba223d34cdcd7b27ef5163a9c
parentf3fa2a5d5c02d8937ee5c866b827a9553c9dd351 (diff)
downloadmeta-openembedded-4b26cded9c747a2d610a8abf0f4549df48a1db5e.tar.gz
jansson: Honour multilib paths
When multilib is enabled, builds fail during package_qa: ERROR: jansson-2.14-r0 do_package: QA Issue: jansson: Files/directories were installed but not shipped in any package: /usr/lib /usr/lib/libjansson.a /usr/lib/pkgconfig /usr/lib/cmake /usr/lib/pkgconfig/jansson.pc /usr/lib/cmake/jansson /usr/lib/cmake/jansson/janssonTargets-noconfig.cmake /usr/lib/cmake/jansson/janssonConfig.cmake /usr/lib/cmake/jansson/janssonConfigVersion.cmake /usr/lib/cmake/jansson/janssonTargets.cmake Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. jansson: 10 installed and not shipped files. [installed-vs-shipped] ERROR: jansson-2.14-r0 do_package: Fatal QA errors were found, failing task. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r--meta-oe/recipes-extended/jansson/jansson/0001-Honour-multilib-paths.patch63
-rw-r--r--meta-oe/recipes-extended/jansson/jansson_2.14.bb4
2 files changed, 66 insertions, 1 deletions
diff --git a/meta-oe/recipes-extended/jansson/jansson/0001-Honour-multilib-paths.patch b/meta-oe/recipes-extended/jansson/jansson/0001-Honour-multilib-paths.patch
new file mode 100644
index 000000000..513d10945
--- /dev/null
+++ b/meta-oe/recipes-extended/jansson/jansson/0001-Honour-multilib-paths.patch
@@ -0,0 +1,63 @@
1From e66885e66a2ce7fd916933b12d1ba523a25141e4 Mon Sep 17 00:00:00 2001
2From: Alex Kiernan <alex.kiernan@gmail.com>
3Date: Mon, 3 Oct 2022 13:25:05 +0100
4Subject: [PATCH] Honour multilib paths
5
6Upstream-Status: Pending
7Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
8---
9 CMakeLists.txt | 14 +++++++-------
10 1 file changed, 7 insertions(+), 7 deletions(-)
11
12diff --git a/CMakeLists.txt b/CMakeLists.txt
13index 39b9ad365f78..bf297e936a72 100644
14--- a/CMakeLists.txt
15+++ b/CMakeLists.txt
16@@ -20,8 +20,8 @@ endif ()
17
18 # Set some nicer output dirs.
19 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/bin)
20-set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lib)
21-set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/lib)
22+set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR})
23+set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR})
24 set(JANSSON_TEMP_DIR ${CMAKE_CURRENT_BINARY_DIR}/tmp)
25
26 # Give the debug version a different postfix for windows,
27@@ -573,14 +573,14 @@ endif ()
28 #
29
30 # Allow the user to override installation directories.
31-set(JANSSON_INSTALL_LIB_DIR lib CACHE PATH "Installation directory for libraries")
32+set(JANSSON_INSTALL_LIB_DIR ${CMAKE_INSTALL_LIBDIR} CACHE PATH "Installation directory for libraries")
33 set(JANSSON_INSTALL_BIN_DIR bin CACHE PATH "Installation directory for executables")
34 set(JANSSON_INSTALL_INCLUDE_DIR include CACHE PATH "Installation directory for header files")
35
36 if(WIN32 AND NOT CYGWIN)
37 set(DEF_INSTALL_CMAKE_DIR cmake)
38 else()
39- set(DEF_INSTALL_CMAKE_DIR lib/cmake/jansson)
40+ set(DEF_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_LIBDIR}/cmake/jansson)
41 endif()
42
43 set(JANSSON_INSTALL_CMAKE_DIR ${DEF_INSTALL_CMAKE_DIR} CACHE PATH "Installation directory for CMake files")
44@@ -633,8 +633,8 @@ option(JANSSON_INSTALL "Generate installation target" ON)
45 if (JANSSON_INSTALL)
46 install(TARGETS jansson
47 EXPORT janssonTargets
48- LIBRARY DESTINATION "lib"
49- ARCHIVE DESTINATION "lib"
50+ LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}"
51+ ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}"
52 RUNTIME DESTINATION "bin"
53 INCLUDES DESTINATION "include")
54
55@@ -644,7 +644,7 @@ if (JANSSON_INSTALL)
56 # Install the pkg-config.
57 install(FILES
58 ${CMAKE_CURRENT_BINARY_DIR}/jansson.pc
59- DESTINATION lib/pkgconfig)
60+ DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
61
62 # Install the configs.
63 install(FILES
diff --git a/meta-oe/recipes-extended/jansson/jansson_2.14.bb b/meta-oe/recipes-extended/jansson/jansson_2.14.bb
index 94bb99ab7..68e24c890 100644
--- a/meta-oe/recipes-extended/jansson/jansson_2.14.bb
+++ b/meta-oe/recipes-extended/jansson/jansson_2.14.bb
@@ -4,7 +4,9 @@ BUGTRACKER = "https://github.com/akheron/jansson/issues"
4LICENSE = "MIT" 4LICENSE = "MIT"
5LIC_FILES_CHKSUM = "file://LICENSE;md5=afd92c4cfc08f4896003251b878cc0bf" 5LIC_FILES_CHKSUM = "file://LICENSE;md5=afd92c4cfc08f4896003251b878cc0bf"
6 6
7SRC_URI = "https://github.com/akheron/${BPN}/releases/download/v${PV}/${BP}.tar.bz2" 7SRC_URI = "https://github.com/akheron/${BPN}/releases/download/v${PV}/${BP}.tar.bz2 \
8 file://0001-Honour-multilib-paths.patch \
9 "
8SRC_URI[sha256sum] = "fba956f27c6ae56ce6dfd52fbf9d20254aad42821f74fa52f83957625294afb9" 10SRC_URI[sha256sum] = "fba956f27c6ae56ce6dfd52fbf9d20254aad42821f74fa52f83957625294afb9"
9 11
10UPSTREAM_CHECK_URI = "https://github.com/akheron/${BPN}/releases" 12UPSTREAM_CHECK_URI = "https://github.com/akheron/${BPN}/releases"