From cc3cc55828251301eccde0745863f75aa74b49ae Mon Sep 17 00:00:00 2001 From: Jens Rehsack Date: Tue, 23 Jun 2020 10:46:13 +0200 Subject: dpdk: fix gcc 10 maybe-uninitialized warning Backport upstream fix of Kevin Traynor : afd2924 examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning With that fix applied, dpdk builds fine with recent poky. Signed-off-by: Jens Rehsack --- ...sec-gw-fix-gcc-10-maybe-uninitialized-war.patch | 53 ++++++++++++++++++++++ recipes-extended/dpdk/dpdk_19.11-20.04.bb | 1 + 2 files changed, 54 insertions(+) create mode 100644 recipes-extended/dpdk/dpdk/0001-examples-ipsec-gw-fix-gcc-10-maybe-uninitialized-war.patch (limited to 'recipes-extended') diff --git a/recipes-extended/dpdk/dpdk/0001-examples-ipsec-gw-fix-gcc-10-maybe-uninitialized-war.patch b/recipes-extended/dpdk/dpdk/0001-examples-ipsec-gw-fix-gcc-10-maybe-uninitialized-war.patch new file mode 100644 index 00000000..3b5a2b3a --- /dev/null +++ b/recipes-extended/dpdk/dpdk/0001-examples-ipsec-gw-fix-gcc-10-maybe-uninitialized-war.patch @@ -0,0 +1,53 @@ +From 6fe3e96ab6e92f8faca9784a46bc33d92790c2b8 Mon Sep 17 00:00:00 2001 +From: Kevin Traynor +Date: Wed, 11 Mar 2020 11:33:00 +0000 +Subject: [PATCH] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +gcc 10.0.1 reports: + +../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: +../examples/ipsec-secgw/ipsec_process.c:132:34: +error: ‘grp.m’ may be used uninitialized in this function + [-Werror=maybe-uninitialized] + 132 | grp[n].cnt = pkts + i - grp[n].m; + | ~~~~~~^~ + +This is a correct warning for the initial execution of the statement. +However, it is the design of the loop that grp[0].cnt will later be +written with the correct value using an initialized grp[0].m before it +is used. + +In order to remove the warning, initialize grp[0].m for the initial and +unused calculation of grp[0].cnt. + +Fixes: 3e5f4625dc17 ("examples/ipsec-secgw: make data-path to use IPsec library") +Cc: stable@dpdk.org + +Upstream-Status: Backport + +Suggested-by: Konstantin Ananyev +Signed-off-by: Kevin Traynor +Acked-by: Konstantin Ananyev +Signed-off-by: Jens Rehsack +--- + examples/ipsec-secgw/ipsec_process.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/examples/ipsec-secgw/ipsec_process.c b/examples/ipsec-secgw/ipsec_process.c +index 2eb5c8b34..37f406d46 100644 +--- a/examples/ipsec-secgw/ipsec_process.c ++++ b/examples/ipsec-secgw/ipsec_process.c +@@ -125,6 +125,7 @@ sa_group(void *sa_ptr[], struct rte_mbuf *pkts[], + void * const nosa = &spi; + + sa = nosa; ++ grp[0].m = pkts; + for (i = 0, n = 0; i != num; i++) { + + if (sa != sa_ptr[i]) { +-- +2.17.1 + diff --git a/recipes-extended/dpdk/dpdk_19.11-20.04.bb b/recipes-extended/dpdk/dpdk_19.11-20.04.bb index 12b6d56e..398d2ec4 100644 --- a/recipes-extended/dpdk/dpdk_19.11-20.04.bb +++ b/recipes-extended/dpdk/dpdk_19.11-20.04.bb @@ -5,6 +5,7 @@ SRC_URI = "git://source.codeaurora.org/external/qoriq/qoriq-components/dpdk;nobr file://0001-add-Wno-cast-function-type.patch \ file://0001-Add-RTE_KERNELDIR_OUT.patch \ file://0004-update-WERROR_FLAGS.patch \ + file://0001-examples-ipsec-gw-fix-gcc-10-maybe-uninitialized-war.patch \ " SRCREV = "4110a5fed09fa034963cfc246a6285911ecbd540" -- cgit v1.2.3-54-g00ecf