From 483e89b6e900daa70ea7abefda84909258eab57e Mon Sep 17 00:00:00 2001 From: Max Krummenacher Date: Thu, 24 Nov 2022 17:59:00 +0100 Subject: isp-imx: prevent oe qa warning As the recipe installs the file 'by hand' rather than using `make install` make sure that the binaries get their final RPATH set during do_compile rather than relying on the CMake produced RPATH magic in `make install`. | WARNING: isp-imx-4.2.2.19.0-r0 do_package_qa: QA Issue: File /usr/lib/libmedia_server.so in package isp-imx contains reference to TMPDIR | File /opt/imx8-isp/bin/isp_media_server in package isp-imx contains reference to TMPDIR [buildpaths] With this the 'INSANE_SKIP:${PN} = "rpaths"' is also no longer needed as the following error is also gone: | ERROR: isp-imx-4.2.2.19.0-r0 do_package_qa: QA Issue: package isp-imx contains bad RPATH $ORIGIN:/.../isp-imx-4.2.2.19.0/dewarp/proprietories/hal/lib: in file .../packages-split/isp-imx/usr/lib/libmedia_server.so | package isp-imx contains bad RPATH $ORIGIN/.../isp-imx-4.2.2.19.0/dewarp/proprietories/hal/lib in file .../packages-split/isp-imx/opt/imx8-isp/bin/isp_media_server [rpaths] Signed-off-by: Max Krummenacher (cherry picked from commit 58ccfda536668e7108111493a4f328e0e42b2cae) --- recipes-bsp/isp-imx/isp-imx_4.2.2.19.0.bb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/recipes-bsp/isp-imx/isp-imx_4.2.2.19.0.bb b/recipes-bsp/isp-imx/isp-imx_4.2.2.19.0.bb index ae96299a..19d0cba7 100644 --- a/recipes-bsp/isp-imx/isp-imx_4.2.2.19.0.bb +++ b/recipes-bsp/isp-imx/isp-imx_4.2.2.19.0.bb @@ -25,6 +25,7 @@ SYSTEMD_SERVICE:${PN} = "imx8-isp.service" EXTRA_OECMAKE += " \ -DSDKTARGETSYSROOT=${STAGING_DIR_HOST} \ -DCMAKE_BUILD_TYPE=release \ + -DCMAKE_BUILD_WITH_INSTALL_RPATH=ON \ -DISP_VERSION=ISP8000NANO_V1802 \ -DPLATFORM=ARM64 \ -DAPPMODE=V4L2 \ @@ -83,8 +84,6 @@ FILES_SOLIBS_VERSIONED = " \ FILES:${PN} += "/opt ${libdir}/lib*${SOLIBSDEV}" FILES:${PN}-dev += "${FILES_SOLIBS_VERSIONED}" -INSANE_SKIP:${PN} = "rpaths" - RDEPENDS:${PN} = "libdrm" COMPATIBLE_MACHINE = "(mx8mp-nxp-bsp)" -- cgit v1.2.3-54-g00ecf