summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOtavio Salvador <otavio@ossystems.com.br>2022-03-08 22:54:26 -0300
committerGitHub <noreply@github.com>2022-03-08 22:54:26 -0300
commit3d48b0fbc85c64b8070c1e2ce54ee84d0329cfeb (patch)
tree5c4ff91a20f533bdf4aae31f19e3e5052ce3c80b
parent6e44702146e8d42c108ae6890b9cdc2b4df9ac50 (diff)
parent9af5e0ce68c1196bfd2f5b971792e80af79bbe69 (diff)
downloadmeta-freescale-3d48b0fbc85c64b8070c1e2ce54ee84d0329cfeb.tar.gz
Merge pull request #1004 from chrisdimich/honister
Backport to Honister: isp-imx: start_isp.sh: fix NR_DEVICE_TREE_BASLER variable
-rw-r--r--recipes-bsp/isp-imx/isp-imx/0001-isp-imx-drop-use-of-__TIME__-__DATE__.patch72
-rw-r--r--recipes-bsp/isp-imx/isp-imx/0001-start_isp.sh-fix-NR_DEVICE_TREE_BASLER-variable.patch41
2 files changed, 8 insertions, 105 deletions
diff --git a/recipes-bsp/isp-imx/isp-imx/0001-isp-imx-drop-use-of-__TIME__-__DATE__.patch b/recipes-bsp/isp-imx/isp-imx/0001-isp-imx-drop-use-of-__TIME__-__DATE__.patch
deleted file mode 100644
index c3ee088f..00000000
--- a/recipes-bsp/isp-imx/isp-imx/0001-isp-imx-drop-use-of-__TIME__-__DATE__.patch
+++ /dev/null
@@ -1,72 +0,0 @@
1From ea5ce303fa5bc7b6a17c522b4caf49d349adb12b Mon Sep 17 00:00:00 2001
2From: Max Krummenacher <max.krummenacher@toradex.com>
3Date: Sat, 30 Oct 2021 17:26:42 +0200
4Subject: [PATCH] isp-imx: drop use of __TIME__, __DATE__
5
6With reproducible build enabled the compiler is configured to throw
7an error if __TIME__, __DATE__ preprocessor macros are used.
8
9| isp-imx-4.2.2.11.0/mediacontrol/daemon/main_v4l2.cpp:99:44: error: macro "__DATE__" might prevent reproducible builds [-Werror=date-time]
10| 99 | std::cout << "Build Time : "<<__DATE__<<", "<<__TIME__<<std::endl;
11| | ^~~~~~~~
12
13Fix this by replacing __DATE__, __TIME__ with BUILD_DATE and setting
14BUILD_DATE from CMakeLists.txt to either SOURCE_DATE_EPOCH if present
15or the local time otherwise.
16
17Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
18---
19 mediacontrol/CMakeLists.txt | 3 +++
20 mediacontrol/daemon/main_v4l2.cpp | 8 ++++----
21 2 files changed, 7 insertions(+), 4 deletions(-)
22
23diff --git a/mediacontrol/CMakeLists.txt b/mediacontrol/CMakeLists.txt
24index 5849c163e..8a8e1a4a0 100755
25--- a/mediacontrol/CMakeLists.txt
26+++ b/mediacontrol/CMakeLists.txt
27@@ -2,6 +2,9 @@ cmake_minimum_required(VERSION 3.1.0)
28
29 project(ISP_MEDIA_CONTROL)
30
31+string(TIMESTAMP BUILD_DATE "%b %d %Y" UTC)
32+add_compile_definitions(BUILD_DATE="${BUILD_DATE}")
33+
34 if( NOT DEFINED APPSHELL_TOP_COMPILE)
35 if(DEFINED PLATFORM)
36 if(${PLATFORM} STREQUAL ARM64)
37diff --git a/mediacontrol/daemon/main_v4l2.cpp b/mediacontrol/daemon/main_v4l2.cpp
38index d3d1c2423..dd0514358 100644
39--- a/mediacontrol/daemon/main_v4l2.cpp
40+++ b/mediacontrol/daemon/main_v4l2.cpp
41@@ -105,7 +105,7 @@ int main(int argc, char* argv[]) {
42 if(!(string2Version.find(argv[1])==string2Version.end())){
43 std::cout << "Version : "<<MEDIA_SERVER_VERSION<<std::endl;
44 #ifndef ANDROID
45- std::cout << "Build Time : "<<__DATE__<<", "<<__TIME__<<std::endl;
46+ std::cout << "Build Time : "<<BUILD_DATE<<std::endl;
47 #endif
48 return 0;
49 }
50@@ -116,8 +116,8 @@ int main(int argc, char* argv[]) {
51 {
52 ALOGI("******************************************************************");
53 #ifndef ANDROID
54- ALOGI("VIV ISP Media Control Framework V%s (%s, %s)",
55- MEDIA_SERVER_VERSION, __DATE__, __TIME__);
56+ ALOGI("VIV ISP Media Control Framework V%s (%s)",
57+ MEDIA_SERVER_VERSION, BUILD_DATE);
58 #else
59 ALOGI("VIV ISP Media Control Framework V%s", MEDIA_SERVER_VERSION);
60 #endif
61@@ -138,7 +138,7 @@ int main(int argc, char* argv[]) {
62 if(!(string2Version.find(argv[i])==string2Version.end())){
63 std::cout << "Version : "<<MEDIA_SERVER_VERSION<<std::endl;
64 #ifndef ANDROID
65- std::cout << "Build Time : "<<__DATE__<<", "<<__TIME__<<std::endl;
66+ std::cout << "Build Time : "<<BUILD_DATE<<std::endl;
67 #endif
68 i++;
69 continue;
70--
712.20.1
72
diff --git a/recipes-bsp/isp-imx/isp-imx/0001-start_isp.sh-fix-NR_DEVICE_TREE_BASLER-variable.patch b/recipes-bsp/isp-imx/isp-imx/0001-start_isp.sh-fix-NR_DEVICE_TREE_BASLER-variable.patch
index 950098cd..bfea33a7 100644
--- a/recipes-bsp/isp-imx/isp-imx/0001-start_isp.sh-fix-NR_DEVICE_TREE_BASLER-variable.patch
+++ b/recipes-bsp/isp-imx/isp-imx/0001-start_isp.sh-fix-NR_DEVICE_TREE_BASLER-variable.patch
@@ -1,17 +1,17 @@
1From 9c65e20b82cfd9e82b849b3140eec7b8c18922dc Mon Sep 17 00:00:00 2001 1From a48c605b9f3860ee7abaca1a37add444a1b4001a Mon Sep 17 00:00:00 2001
2From: Chris Dimich <Chris.Dimich@boundarydevices.com> 2From: Chris Dimich <chris.dimich@boundarydevices.com>
3Date: Mon, 13 Sep 2021 17:56:02 -0700 3Date: Tue, 8 Mar 2022 14:45:28 -0800
4Subject: [PATCH 1/1] start_isp.sh: fix NR_DEVICE_TREE_BASLER variable 4Subject: [PATCH 1/1] start_isp.sh: fix NR_DEVICE_TREE_BASLER variable
5 5
6Also remove uneeded -lm option from run.sh script. 6The NR_DEVICE_TREE_BASLER variable has the wrong path.
7 7
8Signed-off-by: Chris Dimich <Chris.Dimich@boundarydevices.com> 8Signed-off-by: Chris Dimich <chris.dimich@boundarydevices.com>
9--- 9---
10 imx/start_isp.sh | 8 ++++---- 10 imx/start_isp.sh | 2 +-
11 1 file changed, 4 insertions(+), 4 deletions(-) 11 1 file changed, 1 insertion(+), 1 deletion(-)
12 12
13diff --git a/imx/start_isp.sh b/imx/start_isp.sh 13diff --git a/imx/start_isp.sh b/imx/start_isp.sh
14index 6daabc59c..250226935 100755 14index 6daabc59c..8a07acfed 100755
15--- a/imx/start_isp.sh 15--- a/imx/start_isp.sh
16+++ b/imx/start_isp.sh 16+++ b/imx/start_isp.sh
17@@ -7,7 +7,7 @@ 17@@ -7,7 +7,7 @@
@@ -23,31 +23,6 @@ index 6daabc59c..250226935 100755
23 NR_DEVICE_TREE_OV5640=$(grep ov5640 /sys/firmware/devicetree/base/soc@0/*/i2c@*/*/compatible -l | wc -l 2> /dev/null) 23 NR_DEVICE_TREE_OV5640=$(grep ov5640 /sys/firmware/devicetree/base/soc@0/*/i2c@*/*/compatible -l | wc -l 2> /dev/null)
24 24
25 # check if the basler device has been enabled in the device tree 25 # check if the basler device has been enabled in the device tree
26@@ -21,13 +21,13 @@ if [ $NR_DEVICE_TREE_BASLER -eq 1 ]; then
27
28 # Default configuration for Basler daA3840-30mc: basler_4k
29 # Available configurations: basler_4k, basler_1080p60, basler_4khdr, basler_1080p60hdr
30- exec ./run.sh -c basler_4k -lm
31+ exec ./run.sh -c basler_4k
32
33 elif [ $NR_DEVICE_TREE_OV5640 -eq 1 ]; then
34
35 # Default configuration for Basler daA3840-30mc: basler_1080p60
36 # Available configurations: basler_1080p60, basler_1080p60hdr
37- exec ./run.sh -c basler_1080p60 -lm
38+ exec ./run.sh -c basler_1080p60
39
40 fi
41
42@@ -38,7 +38,7 @@ elif [ $NR_DEVICE_TREE_BASLER -eq 2 ]; then
43 cd $RUNTIME_DIR
44 # Default configuration for Basler daA3840-30mc: dual_basler_1080p60
45 # Available configurations: dual_basler_1080p60, dual_basler_1080p60hdr, dual_basler_1080p25hdr
46- exec ./run.sh -c dual_basler_1080p60 -lm
47+ exec ./run.sh -c dual_basler_1080p60
48
49 else
50 # no device tree found exit with code no device or address
51-- 26--
522.31.1 272.31.1
53 28