From f73e0eb5d77764c00d6ae8db10528522fc8516bc Mon Sep 17 00:00:00 2001 From: Sona Sarmadi Date: Mon, 26 Sep 2016 12:18:22 +0200 Subject: openssl: Security fix CVE-2016-6306 affects openssl < 1.0.2i Reference: https://www.openssl.org/news/secadv/20160922.txt Signed-off-by: Armin Kuster Signed-off-by: Sona Sarmadi Signed-off-by: Adrian Dudau --- .../openssl/openssl/CVE-2016-6306.patch | 71 ++++++++++++++++++++++ .../openssl/openssl_1.0.2h.bbappend | 1 + 2 files changed, 72 insertions(+) create mode 100644 recipes-connectivity/openssl/openssl/CVE-2016-6306.patch diff --git a/recipes-connectivity/openssl/openssl/CVE-2016-6306.patch b/recipes-connectivity/openssl/openssl/CVE-2016-6306.patch new file mode 100644 index 0000000..9e7d576 --- /dev/null +++ b/recipes-connectivity/openssl/openssl/CVE-2016-6306.patch @@ -0,0 +1,71 @@ +From ff553f837172ecb2b5c8eca257ec3c5619a4b299 Mon Sep 17 00:00:00 2001 +From: "Dr. Stephen Henson" +Date: Sat, 17 Sep 2016 12:36:58 +0100 +Subject: [PATCH] Fix small OOB reads. + +In ssl3_get_client_certificate, ssl3_get_server_certificate and +ssl3_get_certificate_request check we have enough room +before reading a length. + +Thanks to Shi Lei (Gear Team, Qihoo 360 Inc.) for reporting these bugs. + +CVE-2016-6306 + +Reviewed-by: Richard Levitte +Reviewed-by: Matt Caswell + +Upstream-Status: Backport +CVE: CVE-2016-6306 +Signed-off-by: Armin Kuster + +--- + ssl/s3_clnt.c | 11 +++++++++++ + ssl/s3_srvr.c | 6 ++++++ + 2 files changed, 17 insertions(+) + +Index: openssl-1.0.2h/ssl/s3_clnt.c +=================================================================== +--- openssl-1.0.2h.orig/ssl/s3_clnt.c ++++ openssl-1.0.2h/ssl/s3_clnt.c +@@ -1216,6 +1216,12 @@ int ssl3_get_server_certificate(SSL *s) + goto f_err; + } + for (nc = 0; nc < llen;) { ++ if (nc + 3 > llen) { ++ al = SSL_AD_DECODE_ERROR; ++ SSLerr(SSL_F_SSL3_GET_SERVER_CERTIFICATE, ++ SSL_R_CERT_LENGTH_MISMATCH); ++ goto f_err; ++ } + n2l3(p, l); + if ((l + nc + 3) > llen) { + al = SSL_AD_DECODE_ERROR; +@@ -2167,6 +2173,11 @@ int ssl3_get_certificate_request(SSL *s) + } + + for (nc = 0; nc < llen;) { ++ if (nc + 2 > llen) { ++ ssl3_send_alert(s, SSL3_AL_FATAL, SSL_AD_DECODE_ERROR); ++ SSLerr(SSL_F_SSL3_GET_CERTIFICATE_REQUEST, SSL_R_CA_DN_TOO_LONG); ++ goto err; ++ } + n2s(p, l); + if ((l + nc + 2) > llen) { + if ((s->options & SSL_OP_NETSCAPE_CA_DN_BUG)) +Index: openssl-1.0.2h/ssl/s3_srvr.c +=================================================================== +--- openssl-1.0.2h.orig/ssl/s3_srvr.c ++++ openssl-1.0.2h/ssl/s3_srvr.c +@@ -3213,6 +3213,12 @@ int ssl3_get_client_certificate(SSL *s) + goto f_err; + } + for (nc = 0; nc < llen;) { ++ if (nc + 3 > llen) { ++ al = SSL_AD_DECODE_ERROR; ++ SSLerr(SSL_F_SSL3_GET_CLIENT_CERTIFICATE, ++ SSL_R_CERT_LENGTH_MISMATCH); ++ goto f_err; ++ } + n2l3(p, l); + if ((l + nc + 3) > llen) { + al = SSL_AD_DECODE_ERROR; diff --git a/recipes-connectivity/openssl/openssl_1.0.2h.bbappend b/recipes-connectivity/openssl/openssl_1.0.2h.bbappend index e4a9912..0f635bf 100644 --- a/recipes-connectivity/openssl/openssl_1.0.2h.bbappend +++ b/recipes-connectivity/openssl/openssl_1.0.2h.bbappend @@ -10,4 +10,5 @@ SRC_URI += "file://CVE-2016-2178.patch \ file://CVE-2016-6302.patch \ file://CVE-2016-6303.patch \ file://CVE-2016-6304.patch \ + file://CVE-2016-6306.patch \ " -- cgit v1.2.3-54-g00ecf